feat(sketch): remove deprecated icons from sketch plugin #8060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 6cdb8d1 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 6cdb8d1 https://deploy-preview-8060--carbon-components-react.netlify.app |
87 tasks
4 tasks
emyarod
force-pushed
the
7732-remove-deprecated-icons-from-sketch-plugin
branch
from
9c0b94e
to
0f8fa75
Compare
laurenmrice
approved these changes
Mar 12, 2021
joshblack
approved these changes
Mar 15, 2021
andreancardona
approved these changes
Mar 15, 2021
emyarod
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7732
Related #4195
Related #5015
This PR integrates icon symbol deprecation into the Sketch plugin icon sync commands. When running the icon sync commands deprecated icon symbols on the current document will be removed and no additional symbols of deprecated icons will be created. Previously, the plugin would only exclude deprecated icons from new symbol/artboard creation during the sync command, but now the plugin will also remove existing symbols of deprecated icons
Changelog
New
Testing / Reviewing
Confirm that existing deprecated icons are removed from the current document when icons sync is run and no deprecated icon symbols are created as well. Ensure that there are no regressions with icons sync behavior
carbon-elements.sketchplugin.zip